Skip to content

musa: remove nrows_x in mul_mat_q_process_tile #13325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

musa: remove nrows_x in mul_mat_q_process_tile #13325

merged 1 commit into from
May 7, 2025
+4 −4

Conversation

@yeahdongcn
Copy link
Collaborator

@yeahdongcn yeahdongcn commented May 6, 2025

Make sure to read the contributing guidelines before submitting a PR

Fix a new warning detected by our internal CI.

@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels May 6, 2025
@JohannesGaessler
Copy link
Collaborator

JohannesGaessler commented May 6, 2025

Previously nrows_x was needed to determine the maximum extent of valid memory. I moved that one level higher and forgot to remove the argument in mul_mat_q_process_tile. So it should simply be removed since it's not used for anything (create a new commit from master to avoid a merge conflict).

@yeahdongcn yeahdongcn changed the title musa: fix build warning Remove nrows_x in mul_mat_q_process_tile May 7, 2025
@yeahdongcn
Copy link
Collaborator Author

yeahdongcn commented May 7, 2025

Previously nrows_x was needed to determine the maximum extent of valid memory. I moved that one level higher and forgot to remove the argument in mul_mat_q_process_tile. So it should simply be removed since it's not used for anything (create a new commit from master to avoid a merge conflict).

Thanks for the review! I've updated the PR based on your comments.

@yeahdongcn yeahdongcn changed the title Remove nrows_x in mul_mat_q_process_tile musa: remove nrows_x in mul_mat_q_process_tile May 7, 2025
@CISC CISC merged commit 1f73301 into ggml-org:master May 7, 2025
42 checks passed
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request May 9, 2025
@Nexesenex
Revert "cuda : remove nrows_x in mul_mat_q_process_tile (ggml-org#13325…
4f1275d 
…)"

This reverts commit 1f73301.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

@JohannesGaessler JohannesGaessler Awaiting requested review from JohannesGaessler JohannesGaessler is a code owner

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yeahdongcn @JohannesGaessler @CISC